[Docs] tiny addition about github practices #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @sampsyo @rachitnigam Thoughts about what else should be added or if it should go in a different section? |
rachitnigam
reviewed
Jan 8, 2024
rachitnigam
reviewed
Jan 8, 2024
sampsyo
reviewed
Jan 11, 2024
|
@EclecticGriffin let's resolve this and get it merged? |
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
rachitnigam
pushed a commit
that referenced
this pull request
Feb 16, 2024
* tiny addition about github practices * Change the title * rachit notes * Update docs/github.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> * Update docs/github.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> * Update docs/github.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> * Update docs/github.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> --------- Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be worth fleshing this out in more detail as we ramp up with the new org