Add support for using python builder invoke with integer literals
#1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't think this can do any harm so merging |
|
Wahoo; that'll do nicely! Seems like the right thing to add width inference anywhere we can muster. |
rachitnigam
pushed a commit
that referenced
this pull request
Feb 16, 2024
…1849) * Add support for invoking with integer literals * Update invoke example to have consts * Change example to have a literal instead of const
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was messing around building AXI implementations in python and thought this could be nice. If there are downstream effects I'm not aware of please let me know and I'll try to address them or stop pursuing this if it doesn't seem worth it.
Previously we had to write things like
This PR lets us write write the above as
which is what I initially did before being surprised that it didn't work.
Not sure who has been taking charge of builder stuff so
cc @anshumanmohan @rachitnigam @sampsyo