Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove use of always_comb from binary_operators.sv #2330

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Remove use of always_comb from binary_operators.sv #2330

merged 3 commits into from
Nov 4, 2024

Conversation

rachitnigam
Copy link
Contributor

Changes from #2266 since author has not responded. Fixes #2253.

@rachitnigam rachitnigam mentioned this pull request Nov 3, 2024
Closed
@rachitnigam rachitnigam requested a review from ekiwi November 3, 2024 21:58
ekiwi
ekiwi approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ekiwi ekiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. For correct code, this should behave exactly the same afaik.

awlays_comb just makes it an error to try and describe anything besides combinational logic.

@ekiwi ekiwi merged commit 95fb141 into main Nov 4, 2024
18 checks passed
@ekiwi ekiwi deleted the icarus-always-comb branch November 4, 2024 13:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ekiwi ekiwi ekiwi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor std_fp_div_pipe primitive to avoid Verilog features not supported by Icarus
2 participants
@rachitnigam @ekiwi