cider: use jq stage #2342
Merged
cider: use jq stage #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachitnigam
reviewed
Nov 6, 2024
| @@ -161,7 +161,8 @@ fud2 --from calyx --to dat \ | |||
| --through cider \ | |||
| -s sim.data={}.data \ | |||
| -s calyx.args="--log off" \ | |||
| {} | jq --sort-keys | |||
| -s jq.flags="--sort-keys" \ | |||
There was a problem hiding this comment.
Not related to this PR but: it seems that the only reason cider uses jq is to sort the keys. Can this instead be done within the compiler by using a LinkedHashMap or something right before emitting the data?
There was a problem hiding this comment.
It might be feasible to do in the data converter. Depends a little bit on how the Rust JSON library does things, since that is used to generate the JSON. I don't think it is important enough to do anything about it right now though.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I overlooked Rachit's comment on the previous PR.