data-converted: always sort keys in output JSON #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rachitnigam : Let me know if you want to get #2341 in first. In that case, I can rebase this PR. Otherwise, #2341 will have to rebase after we merge this. |
|
LGTM! Let's get #2341 in first and then merge this. |
ekiwi
force-pushed
the
data-converted-sorted-keys
branch
from
221a4e5 to
fd4c216
Compare
ekiwi
force-pushed
the
data-converted-sorted-keys
branch
from
fd4c216 to
a98ea57
Compare
|
Awesome! Probably should've thought to do this ages ago! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this works