Queues: add instructions for converting tests to Calyx #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely will not merge without confirmation that these tweaks to CI are okay since they affect everyone |
|
Just on the CI stuff I think this is good and we should merge it to avoid some CI brittleness in the future |
anshumanmohan
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Looks great, thank you! Tbh the CI stuff would have gone over my head so I'm grateful for @EclecticGriffin's check. Merge away!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is says on the tin (as discussed on this slack thread)
Due to a new release for rust, CI catches a few errors (unrelated to this PR). For now, we simply pin to an older version:
setup-rust-toolchain@v1inrust.ymlrust-toolchain.toml