-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Release r1.1 (Release Candidate) #71
base: main
Are you sure you want to change the base?
Conversation
Hi @PedroDiez thanks for creating the release PR. I've created for the review camaraproject/ReleaseManagement#138, but seems we need to wait until the open PRs are merged. The release PR
Minor point: |
Hi @hdamker, Thanks for the comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR needs updates, and the other PRs should be merged before this on. this should be the last PR to merge.
CHANGELOG.md
Outdated
@@ -2,12 +2,70 @@ | |||
|
|||
## Table of Contents | |||
|
|||
- [r2.1 - rc](#r11---rc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change #r11 to #r21
the "---rc" is optional and is not to be used in the actual release tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanjadegroot could it be that the only mistake regarding the release number is in this line? That it should be:
- [r2.1 - rc](#r11---rc) | |
- [r1.1 - rc](#r11---rc) |
It's the first participations of the API Repository in a meta-release, as @PedroDiez in my view rightfully commented. Than r1.1 should be ok across the other files. Just here in the table of content it was wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will review is r1.1 across all documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If indeed this is the first release and the v0.1.0 in the CHANGELOG is the same, then the V0.1.0 should be replaced by r1.1 indeed. However, there was already an (alpha) release v0.1.0 pre-released before and a tag was created. This is a first pre-release version of a new target v0.2.0 (v0.2.0-rc.1) API, logically it should be called r2.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you have done all the changes already to r1.1, then go with r1.1 - fine for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I keep r1.1
- [v0.1.0](#v010) | ||
|
||
**Please be aware that the project will have frequent updates to the main branch. There are no compatibility guarantees associated with code in any branch, including main, until it has been released. For example, changes may be reverted before a release is published. For the best results, use the latest published release.** | ||
|
||
The below sections record the changes for each API version in each release as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change lines 10-14 by the latest version (from ReleaseManagement/documentation/CHANGELOG_TEMPLATE.md):
The below sections record the changes for each API version in each release as follows:
- for an alpha release, the delta with respect to the previous release
- for the first release-candidate, all changes since the last public release
- for subsequent release-candidate(s), only the delta to the previous release-candidate
- for a public release, the consolidated changes since the previous public release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* for subsequent alpha or release-candidate API versions, the delta with respect to the previous pre-release | ||
* for a public API version, the consolidated changes since the release of the previous public API version | ||
|
||
## r1.1 - rc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tanjadegroot this API has never had a former release within "Metarelease" tracks.
Even so we should use r2.1 as r1.x was the one used within MetaRelease Fall24? Just to double check as i am involved in other API with the same scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay in answering. the release numbering (1.x, 2.x, etc) is not linked to the meta-release.
it is used for tracking progress/history of the API development and publication, but for pre-releases and public release. Release number increase with each new target release (be it in a meta-release or not), so I think it should be r2.1 as you changed from a 0.1.0 target to a 0.2.0 target which normally would have different release trackers.
But as said above, if you have already updated the files to use r1.1, it is fine with me.
CHANGELOG.md
Outdated
|
||
The API definition(s) are based on | ||
* Commonalities v0.5.0-rc.1 | ||
* Identity and Consent Management v0.3.0-alpha.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use v0.3.0-rc.1 (release PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
* **The Release [r1.1 - rc](https://github.com/camaraproject/BlockchainPublicAddress/blob/main/CHANGELOG.md#r1.1---rc) for the Blockchain Public Address APIs Family is available.** | ||
<br>This is a release candidate. Until the public release there are bug fixes to be expected. The release candidate is suitable for implementors, but it is not recommended to use the API with customers in productive environments. | ||
|
||
* The release **r1.1 - rc** is available in [r1.1](https://github.com/camaraproject/BlockchainPublicAddress/tree/r2.1), and includes the following APIs: | ||
* API definition of Blockchain Public Address API is 0.1.0 (with inline documentation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.1.0 --> 0.2.0-rc.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
README.md
Outdated
- [View it on Swagger Editor](https://editor.swagger.io/?url=https://raw.githubusercontent.com/camaraproject/BlockchainPublicAddress/r1.1/code/API_definitions/blockchain-public-address.yaml) | ||
- OpenAPI [YAML spec file](https://github.com/camaraproject/BlockchainPublicAddress/blob/r1.1/code/API_definitions/blockchain-public-address.yaml) | ||
|
||
* Other releases of this sub project are available in [BlockchainPublicAddress Releases](https://github.com/camaraproject/BlockchainPublicAddress/releases) | ||
* For changes see [CHANGELOG.md](https://github.com/camaraproject/BlockchainPublicAddress/blob/main/CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use here a local URL reference: CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Some updates needed and PRs still to be merged before the release PR can be merged. |
I will wait to make updates until merge of PRs
So i can also address some minor points (e.g. version and servers.url adaptation) |
Please try to have that done this week. |
Have manage comments. Waiting to merge #69 first and align branch |
What type of PR is this?
What this PR does / why we need it:
Blockchain Public Address Release r1.1 (Release Candidate) PR (Spring25)
Which issue(s) this PR fixes:
Fixes #66
Fixes #63
Fixes #65
Fixes #64
Special notes for reviewers:
The following PRs MUST be merged prior to this one:
Update User Stories filename in #67
API Spec aligment with Commonalities and ICM in #69
Basic Test cases definition in #70
Generate API Readiness Checklist in #68
Changelog input
Additional documentation
This section can be blank.