Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update location-retrieval with x-correlator #172

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Mar 12, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Update location-retrieval with x-correlator
This PR partially solve Issue #160
(2 other PR come for the 2 other APIs)

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

/!\ Changed the version to version: 0.2.0-wip
Alignement with CAMARA Guidelines

Changelog input

 release-note
- add x-correlator as parameter for location-retrieval

Additional documentation

This section can be blank.

docs

Update location-retrieval with x-correlator
This PR partially solve Issue #160
(2 other PR will come for the 2 other APIs)
@bigludo7 bigludo7 requested a review from jlurien as a code owner March 12, 2024 14:20
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM comparing with other APIs, but I opened an issue in Commonalities to discuss about the UUID pattern in the Guidelines camaraproject/Commonalities#166

@bigludo7 bigludo7 merged commit 3a4314a into main Mar 26, 2024
@bigludo7 bigludo7 deleted the bigludo7-patch-3 branch March 26, 2024 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants