Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement opennode payments processor #315

Merged
merged 1 commit into from
May 23, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented May 23, 2023

Description

  1. Implement OpenNode payments processor
  2. Refactor request handlers and controllers to keep code DRY

Related Issue

#314

Motivation and Context

  1. Give relay operators more choice when it comes to payments processors

How Has This Been Tested?

  1. Manually paying invoices

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri self-assigned this May 23, 2023
@cameri cameri linked an issue May 23, 2023 that may be closed by this pull request
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5058928166

  • 97 of 258 (37.6%) changed or added relevant lines in 23 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 55.059%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/factories/controllers/lnbits-callback-controller-factory.ts 5 6 83.33%
src/factories/controllers/opennode-callback-controller-factory.ts 3 4 75.0%
src/factories/controllers/zebedee-callback-controller-factory.ts 3 4 75.0%
src/factories/payments-processor-factory.ts 5 6 83.33%
src/utils/transform.ts 4 5 80.0%
src/factories/controllers/get-invoice-status-controller-factory.ts 4 7 57.14%
src/handlers/request-handlers/with-controller-request-handler.ts 1 4 25.0%
src/factories/controllers/post-invoice-controller-factory.ts 7 11 63.64%
src/factories/payments-processors/lnurl-payments-processor-factory.ts 5 10 50.0%
src/factories/payments-processors/nodeless-payments-processor-factory.ts 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
src/controllers/callbacks/nodeless-callback-controller.ts 1 15.69%
src/controllers/callbacks/zebedee-callback-controller.ts 1 13.46%
Totals Coverage Status
Change from base Build 5027620282: -0.003%
Covered Lines: 1282
Relevant Lines: 2292

💛 - Coveralls

@cameri cameri merged commit df1a364 into main May 23, 2023
@cameri cameri deleted the 314-implement-opennode-as-payments-processor branch May 23, 2023 15:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

29.5% 29.5% Coverage
5.6% 5.6% Duplication

github-actions bot pushed a commit that referenced this pull request May 23, 2023
# [1.25.0](v1.24.1...v1.25.0) (2023-05-23)

### Bug Fixes

* generic tag queries not accepting uppercase letters ([#312](#312)) ([7331f95](7331f95))

### Features

* implement opennode payments processor ([#315](#315)) ([df1a364](df1a364))
@github-actions
Copy link

🎉 This PR is included in version 1.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OpenNode as Payments Processor
2 participants