Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: confirm invoice missing params #320

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: confirm invoice missing params #320

merged 1 commit into from
May 25, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented May 25, 2023 •
edited
Loading

Description

  1. Confirming invoice no longer fails because of missing data

Related Issue

#319

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri linked an issue May 25, 2023 that may be closed by this pull request
Unable to confirm invoice #319
Closed
@cameri cameri changed the title fix: confirm invoice confirmedAt is undefined fix: confirm invoice missing params May 25, 2023
@cameri cameri self-assigned this May 25, 2023
@cameri cameri added the bug Something isn't working label May 25, 2023
@cameri cameri merged commit e0e3a11 into main May 25, 2023
@cameri cameri deleted the 319-unable-to-confirm-invoice branch May 25, 2023 13:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

github-actions bot pushed a commit that referenced this pull request May 25, 2023
@semantic-release-bot
chore(release): 1.25.2 [skip ci]
a63c035 
## [1.25.2](v1.25.1...v1.25.2) (2023-05-25)

### Bug Fixes

* confirm invoice confirmedAt is undefined ([#320](#320)) ([e0e3a11](e0e3a11))
@github-actions
Copy link

🎉 This PR is included in version 1.25.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cameri cameri

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to confirm invoice
1 participant
@cameri