Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

migrate to dotenv for configs #75

Merged
merged 1 commit into from
Mar 14, 2021
Merged

migrate to dotenv for configs #75

merged 1 commit into from
Mar 14, 2021

Conversation

YashKumarVerma
Copy link
Contributor

@YashKumarVerma YashKumarVerma commented Mar 10, 2021

Fixes #74

Description

  • lists all environment configs into a file named .env.example following the same convention that was used for the routes file.
  • adds a line in the readme to inform users about .env.example usage

Motivation and Context

  • allows hot swapping config sets.
  • no need to pass values mentally.

How Has This Been Tested?

  • locally, yes.
  • no changes in test suite.

Screenshots (if appropriate):

image

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@YashKumarVerma YashKumarVerma marked this pull request as ready for review March 12, 2021 07:54
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me :)

@birm birm changed the base branch from master to develop March 14, 2021 05:08
@birm birm merged commit 0c78428 into camicroscope:develop Mar 14, 2021
@birm birm mentioned this pull request Apr 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use dotenv to handle environment variables
2 participants