Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix heatmap range slider bug [Closes #380] #381

Merged
merged 4 commits into from
Apr 17, 2020

Conversation

cjchirag7
Copy link
Contributor

Description

  • Whenever user changes the field or mode, heatmap.resize() is called, so as to produce the desired results and fix the bug.
  • The bounding box has been initialised at the beginning

Motivation and Context

How Has This Been Tested?

  • Tested in both Chrome and Firefox
  • Also, the bounding box was not initialised at the beginning earlier, resulting in slower loading of the page

Screencast :

heatmap-fix-bug

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cjchirag7
Copy link
Contributor Author

cjchirag7 commented Apr 17, 2020

Little surprising! Just removing unnecessary console logs made to pass the unit tests 😀

@birm birm self-requested a review April 17, 2020 14:36
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing this. 😃

@birm birm merged commit 717dbf5 into camicroscope:develop Apr 17, 2020
@cjchirag7 cjchirag7 deleted the fix-heatmap-bugs branch April 17, 2020 18:07
@birm birm mentioned this pull request Apr 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants