Moving points #532
Merged
Moving points #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
approved these changes
Jul 6, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving points - Milestone 2
Moving points #523
Contains
I have added a general annotation utility of moving points in which the user can drag annotation after drawing it. I tested it, it works well in all scenarios (zoom, shape) (with smartpen as well).
Currently, only the draw tool utilizes this feature.
Why?
It's easier for users to drag and get perfect annotations than drawing it.
Code details
Added in
openseadragon-canvas-draw-overlay(in the startDrawing, Drawing, __endNewfeature, misc functions)Further reading
My blog
Feel free to provide suggestions, improvements, contributions. And please review