Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow setting a custom output file which will contain all types, fixes #9 #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wwsean08
Copy link

@wwsean08 wwsean08 commented Jun 4, 2017

Adding a new flag to set a custom output file will allow you to set a single file for all the code to go into which essentially works around the problem in issue #9, one other possible solution is to clear the buffer at the end of the loop but it all depends on how you want this program to work (I can see reasons both individual files or a file for each one).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@wwsean08
Copy link
Author

wwsean08 commented Jun 4, 2017

I signed it!

That being said it's not letting me put the email address i use for git commits in as an alternative saying it's associated with another account

@googlebot
Copy link

CLAs look good, thanks!

@wwsean08
Copy link
Author

@campoy any chance you can look at this, just noticed this has been sitting around

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants