Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add the list of the supported column types in the editing. #10655

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

sbrunner
Copy link
Member

No description provided.

@github-actions
Copy link

See also: GEO-6770

* ``time without time zone``
* ``timestamp without time zone``

Note that the following types will not working correctly with the timezone:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence is grammatically incorrect,
but more importantly: it is not clear why a type "with time zone" will not work correctly with the timezone. Is it a bug in GMF? Or what exactly is not working?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GeoMapFish first implementation uses the types ... without time zone then the other one needs a specific development....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we saying the following?
"Note that the following timezone related types are currently not supported:"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your sentences...
We provide a list of types not of timezones...

Copy link
Member

@arnaud-morvan arnaud-morvan Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so can you replace:

Note that the following types will not working correctly with the timezone:

by

Note that the following timezone aware types are currently not supported:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants