Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix issue regarding grafana 6.7 / cleanup datasource request #73

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

cordula-grau
Copy link

This fixes #72

Remove data from alert requests since it is already translated to the filter query string.

@d9705996
Copy link

d9705996 commented Mar 26, 2020

I have tested the changes in this PR with Grafana 6,.7.1 and confirm they fix #72

@Wiebelt
Copy link

Wiebelt commented Mar 27, 2020

I can also confirm this fixes #72 with Grafana 6.7.1, awesome, thanks! 👍

@drewboswell
Copy link

This does the trick! @cryptobioz , @ScottBrenner can you look into merging this please?

@sergiohl1324
Copy link

Yes, This fix for me un Grafana 6.7.1. Thanks !!

@aschleifer
Copy link

Is there any chance to see this merged and released soon? We are using this but we would like to stay on released versions.

@AtebMT
Copy link

AtebMT commented Apr 2, 2020

I'd like to also see this merged soon. We're using a docker image to run Grafana and it pulls down released versions of the plugins into the container. Rather not worry about patching the plugin and have it overwritten next time we make any changes to the Grafana configuration.

@crazydisi
Copy link

Please merge, the PR seems to work flawless.

@HaveFun83
Copy link

@cryptobioz any news here?

@CAReyes
Copy link

CAReyes commented Apr 14, 2020

Hello, we are getting this bug as well. Can we get an update as to when this will be merged?
Thanks!

@mamedin
Copy link

mamedin commented Apr 17, 2020

I tested this PR and it works fine with grafana v6.7.2. Nice work, thanks!

@cryptobioz
Copy link
Member

Thanks @cordula-grau for this PR! Sorry for the delay, I'll publish a new release soon.

@cryptobioz cryptobioz merged commit 73ac603 into camptocamp:master Apr 17, 2020
@elcomtik
Copy link

Can you please publish the release?

@rgarrigue
Copy link

Ping @cryptobioz, please release it now it's merged

@mwennrich
Copy link

please release :-)

@cryptobioz
Copy link
Member

The release 0.0.8 is out! Its addition in the list of official plugins is pending : grafana/grafana-plugin-repository#603

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support grafana 6.7