Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Upgrade to Python 3.11 #33

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Upgrade to Python 3.11 #33

merged 1 commit into from
Apr 10, 2024

Conversation

vuilleumierc
Copy link
Member

@vuilleumierc vuilleumierc commented Apr 10, 2024 •
edited
Loading

Python 3.7 is end-of-life.
With the new FastAPI version, if using curl it is required to set the the header 'Content-Type: application/json' in the request (if not a 422 Unprocessable Entity is returned)

@vuilleumierc vuilleumierc requested a review from danduk82 April 10, 2024 11:43
danduk82
danduk82 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@danduk82 danduk82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but beware then that this is a breaking change. Might be worth to explicitely communicate the need to set the content-type to our the affected clients.
(possibly add an explicit entry in the readme maybe?)

@vuilleumierc vuilleumierc force-pushed the GEO-5958-upgrade-python branch from f95401d to cc8c9d5 Compare April 10, 2024 12:22
@vuilleumierc vuilleumierc merged commit 0ebd4a7 into master Apr 10, 2024
2 checks passed
@vuilleumierc vuilleumierc deleted the GEO-5958-upgrade-python branch April 10, 2024 12:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danduk82 danduk82 danduk82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vuilleumierc @danduk82