Expose entire secret contents in .full
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @raphink what do you think? |
|
LGTM, but maybe the field could be called something clearer, such as |
|
Sure, I'll fix! |
phillipj
force-pushed
the
expose-secret-string
branch
from
320d6fd to
5ae7e03
Compare
phillipj
changed the title
.string.full
|
Renamed attribute from |
|
Thanks for merging! As I'm not known with your normal flow here, I'm curious how often you create and upload new versions? No worries if you are waiting for more changes to be merged before cutting a release, I'll just build a temporary linux & mac version for own purposes. |
|
I've made a custom beta build if anyone else is eager to get their hands on the |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes would allow the entire secret contents to be retrieved from a data source in the
.stringattribute, as suggested in #8.Although "string" is a very fluffy term, I went with what gopass is already using:
Secret.String().Any thoughts?