Skip to content

Commit

Permalink
Rename MnAdminUserConfiguration to AdminUserCreator (no "mn" prefix b…
Browse files Browse the repository at this point in the history
…ecause we are not overwritting any Camunda classes)
  • Loading branch information
tobiasschaefer authored and martisaw committed Dec 22, 2020
1 parent c3862f6 commit 6c9ee5b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@
// Implementation based on: https://github.com/camunda/camunda-bpm-platform/blob/master/spring-boot-starter/starter/src/main/java/org/camunda/bpm/spring/boot/starter/configuration/impl/custom/CreateAdminUserConfiguration.java
@Singleton
@Requires(property = "camunda.bpm.admin-user.id")
public class MnAdminUserConfiguration implements BeanCreatedEventListener<ProcessEngine> {
private static final Logger log = LoggerFactory.getLogger(MnAdminUserConfiguration.class);
public class AdminUserCreator implements BeanCreatedEventListener<ProcessEngine> {
private static final Logger log = LoggerFactory.getLogger(AdminUserCreator.class);

protected final Configuration.AdminUser adminUser;
protected final SynchronousTransactionManager<Connection> transactionManager;

public MnAdminUserConfiguration(Configuration configuration, SynchronousTransactionManager<Connection> transactionManager) {
public AdminUserCreator(Configuration configuration, SynchronousTransactionManager<Connection> transactionManager) {
adminUser = configuration.getAdminUser();
this.transactionManager = transactionManager;
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package info.novatec.micronaut.camunda.bpm.feature.test

import info.novatec.micronaut.camunda.bpm.feature.Configuration
import info.novatec.micronaut.camunda.bpm.feature.MnAdminUserConfiguration
import info.novatec.micronaut.camunda.bpm.feature.AdminUserCreator
import io.micronaut.context.ApplicationContext
import io.micronaut.context.event.BeanCreatedEvent
import io.micronaut.core.value.PropertyNotFoundException
Expand All @@ -19,14 +19,14 @@ import java.util.*
import javax.inject.Inject

/**
* Tests for [info.novatec.micronaut.camunda.bpm.feature.MnAdminUserConfiguration]
* Tests for [info.novatec.micronaut.camunda.bpm.feature.AdminUserCreator]
*
* @author Titus Meyer
*/
class MnAdminUserConfigurationTest {
class AdminUserCreatorTest {
@MicronautTest
@Nested
inner class MnAdminUserConfigurationTestWithoutProperties {
inner class AdminUserCreatorTestWithoutProperties {
@Inject
lateinit var processEngine: ProcessEngine

Expand All @@ -42,22 +42,22 @@ class MnAdminUserConfigurationTest {

@MicronautTest(propertySources = ["classpath:adminusertest.yml"])
@Nested
inner class MnAdminUserConfigurationTestWithProperties {
inner class AdminUserCreatorTestWithProperties {
@Inject
lateinit var processEngine: ProcessEngine

@Inject
lateinit var configuration: Configuration

@Inject
lateinit var mnAdminUserConfiguration: Optional<MnAdminUserConfiguration>
lateinit var adminUserCreator: Optional<AdminUserCreator>

@Inject
lateinit var applicationContext: ApplicationContext

@Test
fun adminUserCreated() {
assertTrue(mnAdminUserConfiguration.isPresent)
assertTrue(adminUserCreator.isPresent)

assertEquals("admin", configuration.adminUser.id)
assertEquals("password", configuration.adminUser.password)
Expand All @@ -73,7 +73,7 @@ class MnAdminUserConfigurationTest {
fun adminUserCreationCalledAgain() {
val event: BeanCreatedEvent<ProcessEngine> = BeanCreatedEvent(applicationContext, null, null, processEngine)

mnAdminUserConfiguration.get().onCreated(event)
adminUserCreator.get().onCreated(event)

assertEquals(1, processEngine.identityService.createUserQuery().count())
assertAdminUserExists(processEngine, configuration.adminUser.id)
Expand Down

0 comments on commit 6c9ee5b

Please # to comment.