Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for Generic Properties #126

Closed
tobiasschaefer opened this issue Nov 26, 2020 · 1 comment
Closed

Support for Generic Properties #126

tobiasschaefer opened this issue Nov 26, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tobiasschaefer
Copy link
Collaborator

tobiasschaefer commented Nov 26, 2020

We currently support some properties and the ProcessEngine Configuration and JobExecutor Configuration can be overwritten programmatically.

It would be nice to support generic properties as well, similar to the Camunda Spring Boot Starter, see https://docs.camunda.org/manual/latest/user-guide/spring-boot-integration/configuration/#generic-properties

Here is a list of configuration properties: https://docs.camunda.org/manual/latest/reference/deployment-descriptors/tags/process-engine/#configuration-properties

Todo

  • make sure that the property values are overwritten if this is done programmatically, e.g. in ProcessEngineConfigurationCustomizer or JobExecutorCustomizer
  • document feature and order of property evaluation in README.md
  • Please also add a test to verify that this works with a property whose behavior is easily testable.
@tobiasschaefer tobiasschaefer added the enhancement New feature or request label Nov 26, 2020
@tobiasschaefer tobiasschaefer added the good first issue Good for newcomers label Nov 30, 2020
@Hayvon Hayvon self-assigned this Dec 4, 2020
@Hayvon
Copy link
Contributor

Hayvon commented Dec 11, 2020

Current implementation status can be found here: https://github.com/Hayvon/micronaut-camunda-bpm/tree/genericProperties

Done:

  • Properties can now be set via camunda.bpm.generic-properties.properties
  • Application throws exception when undefined properties are set
  • Provisional type recognition
  • Test added

ToDo:

@Hayvon Hayvon removed their assignment Dec 11, 2020
tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Dec 23, 2020
tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Dec 23, 2020
tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Jan 5, 2021
tobiasschaefer added a commit to tobiasschaefer/micronaut-camunda-bpm that referenced this issue Jan 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants