recursively black format sheet2linkml codebase #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
This looks great! Could you please add a GitHub Action to check whether new code is formatted as per black standards? You could also update the CONTRIBUTORS.md to let users/contributors should run poetry run black before submitting a PR. If their of those are too much work for this PR, feel free to merge it in now and open them as issues to be fixed later.
|
Thanks @gaurav. I've added a Github Action which checks if the code has been formatted per black standards, and updated the contributor docs too. Feel free to go through it again, and I can merge if everything looks good. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to recursively format all files in the current version of the codebase so we can proceed to implementing the Github Action that automatically creates the LinkML YAML output in this repo as specified in issue #13.