Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrated from $ENV syntax to liquid to support composite context passing #319

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

jsoverson
Copy link
Contributor

@jsoverson jsoverson commented Jun 22, 2023

This PR:

  • Removes the ability to use bash-like syntax to access ENV variables.
  • Adds liquid-template support to important parts of config:
    • with: config passing
    • in resources
    • in test data
  • Note: App configurations (and test config) are the only places where ctx.env is populated. Composite components must define the configuration they need rather than relying on $ENV.
  • Adds root component config & operation level config definition and passing to composite components, http components, and sql components (though sql components do not have any ways of accessing this data as of this PR)
  • added --op_with= cli arg to wick invoke to pass operation-level config (open to naming suggestions)

@fawadasaurus fawadasaurus merged commit 7ab25d2 into main Jun 22, 2023
@fawadasaurus fawadasaurus deleted the composite-context branch June 22, 2023 13:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants