-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix race condition in reboot_check_test's renderer test and add lsusb/lspci timeout (BugFix) #1671
Open
tomli380576
wants to merge
8
commits into
main
Choose a base branch
from
reboot_check_race_condition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1671 +/- ##
==========================================
+ Coverage 48.99% 49.02% +0.02%
==========================================
Files 372 372
Lines 40321 40341 +20
Branches 6811 6814 +3
==========================================
+ Hits 19757 19777 +20
Misses 19842 19842
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
344519d
to
0257922
Compare
1 task
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved issues
Race condition issue: #1631 TLDR: Calling unity_support_test before graphical.target is reached will falsely report the test as failed since it can't open the display.
There was also an issue reported by Hanhsuan where lspci and lsusb can get stuck and never return, so I added a timeout for their
subprocess.run
calls.Documentation
The wait timeout can be controlled by
--graphical-target-timeout <timeout_seconds>
. This value is ignored when-g
or--graphics
are not specified. Default is 120 secondsTests
Unit tests