Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent the state doesn't be changed issue with NV driver (Bugfix) #1679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanhsuan
Copy link
Contributor

@hanhsuan hanhsuan commented Jan 13, 2025

Description

While cycle updating the configuration with NVIDIA (Xorg) devices, it might failed with GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: The requested configuration is based on stale information, however user could use the gnome control center to change the same display configuration without any error. Therefore, get the current state before _apply_monitors_config in the cycle to avoid this issue.

Resolved issues

Documentation

Tests

Tested with the same script in #1576 on intel, AMD and NVIDIA devices.

@hanhsuan hanhsuan changed the title Prevent the state doesn't be changed issue with NV driver Prevent the state doesn't be changed issue with NV driver (Bugfix) Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.30%. Comparing base (77728a6) to head (41ebb55).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1679   +/-   ##
=======================================
  Coverage   49.30%   49.30%           
=======================================
  Files         373      373           
  Lines       40454    40455    +1     
  Branches     6834     6834           
=======================================
+ Hits        19946    19947    +1     
  Misses      19783    19783           
  Partials      725      725           
Flag Coverage Δ
checkbox-support 61.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanhsuan hanhsuan force-pushed the fix_nv_dbus_state_issue branch from 810d44b to e13bc31 Compare January 14, 2025 00:37
@hanhsuan hanhsuan marked this pull request as ready for review January 14, 2025 01:21
@fernando79513 fernando79513 self-assigned this Feb 14, 2025
@fernando79513
Copy link
Collaborator

This review should be quite straightforward. Please merge this branch to main, since the sru-gate validation issue should be solved there.

@p-gentili p-gentili self-assigned this Feb 21, 2025
@p-gentili
Copy link
Collaborator

Hey @hanhsuan, I'll need you to rebase your branch on main to make it pass CI.

@hanhsuan hanhsuan force-pushed the fix_nv_dbus_state_issue branch from e13bc31 to 41ebb55 Compare February 21, 2025 12:08
@hanhsuan
Copy link
Contributor Author

@p-gentili I've rebased. Thanks for your help.

@p-gentili
Copy link
Collaborator

Tested with the same script in #1576 on intel, AMD and NVIDIA devices.

Can you please point to the speific test cases?

@hanhsuan
Copy link
Contributor Author

Tested with the same script in #1576 on intel, AMD and NVIDIA devices.

Can you please point to the speific test cases?

The test case is under developing and will be used to replace id: graphics/{index}_resolution-change_{product_slug} and id: graphics/{index}_rotation_{product_slug} in 24.04 and above.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants