General purpose camera pipeline in checkbox_support (New) #1741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This PR is the 1st part of the previously implemented automatic gstreamer pipeline that was too big)
This PR adds a general purpose pipeline runner
run_pipeline
in checkbox_support and an example driver codetake_photo
that takes a photo using this runnerResolved issues
#1676 <-- was too big for review
Documentation
I drafted a short design doc to explain some of the weirdness/quirks in the code that might not be fully explained by the comments. Hopefully this helps with the review :)
Tests
Unit tests. Also tested on real devices with USB cameras using the following driver code
Intel MIPI are expected to fail for now since they are only accessible with v4l2src, which isn't exposed in DeviceMonitor.
This also plays well with checkbox timeout: