Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix unit tests failing due to bad usage of "add_relation" #5

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

gregory-schiano
Copy link
Contributor

Due to a bad usage of "add_relation" method of Harness, the unit tests started to fail with ops 1.5.3 (which is more strict in validating data relations, see canonical/operator#786)

@gregory-schiano gregory-schiano requested a review from a team as a code owner October 20, 2022 12:47
Copy link
Collaborator

@arturo-seijas arturo-seijas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gtrkiller gtrkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregory-schiano gregory-schiano merged commit 6dfc490 into main Oct 20, 2022
@gregory-schiano gregory-schiano deleted the bugfix/isd-242-fix-unit-tests-with-ops-1-5-3 branch October 20, 2022 13:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants