Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: bump node from 20 to 21 #43

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

abbiesims
Copy link
Contributor

@abbiesims abbiesims commented Jan 8, 2025

Done

  • Bumps Node version from 20 to 21.
  • Currently on Charmhub.io, we have some dependency conflicts when trying to upgrade packages as they require a higher version of Node.

How to QA

  1. Run a project
  • git clone https://github.com/canonical-web-and-design/charmhub.io/
  • cd charmhub.io
  • dotrun
  1. Check the node version being used
  • dotrun exec node -v
  • In this case, it should output v20.16.0
  1. Check-out this branch
  2. Build this image docker build . --tag canonicalwebteam/dotrun-image:local
  3. Run this image docker run -it -p 8045:8045 canonicalwebteam/dotrun-image:local /bin/bash
  4. Build Charmhub.io again (dotrun build)
  5. Node version should now be >= 21.0.0
  6. Run Charmhub.io again (dotrun)

@samhotep samhotep self-assigned this Jan 9, 2025
Copy link
Member

@samhotep samhotep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also Bumped the version to 1.2.0

@abbiesims abbiesims merged commit 84f32fe into main Jan 9, 2025
2 checks passed
@abbiesims abbiesims deleted the chore/upgrade-node-version branch January 9, 2025 11:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants