Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: relation_broken.emit() takes a relation, not a relation ID #369

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

Issue

A broken test (not noticeable at the moment, although it's not doing the right thing, but noticeable with the snapshot changes in canonical/operator#1372).

Solution

Pass the correct argument to relation_broken.emit()

Context

ops?

Testing Instructions

tox -e unit

Upgrade Notes

N/A

@tonyandrewmeyer tonyandrewmeyer requested a review from a team as a code owner December 18, 2024 22:36
Copy link
Contributor

@mmkay mmkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @tonyandrewmeyer!

@mmkay mmkay merged commit 807317c into canonical:main Dec 19, 2024
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants