Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: replace traefik with istio-ingress for public ingress #231

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

wood-push-melon
Copy link
Contributor

@wood-push-melon wood-push-melon commented Nov 27, 2024

This pull request aims to drop traefik-k8s and use istio-ingress-k8s charm for public ingress.

Note:

  • For internal ingress, we need the feature support in istio-ingress-k8s. Therefore, we are still using the traefik-k8s charm for it. We'll come back to it when istio-ingress-k8s charm supports that.

@wood-push-melon wood-push-melon marked this pull request as ready for review November 28, 2024 01:14
@wood-push-melon wood-push-melon requested a review from a team as a code owner November 28, 2024 01:14
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no charm changes were required? Cool.

For the internal ingress my understanding was that we will drop that and use the mesh interface instead, or maybe I misunderstood?

@wood-push-melon @shipperizer should we keep tests for traefik to be sure that we don't break that integration or we no longer care about that??

@wood-push-melon
Copy link
Contributor Author

So no charm changes were required? Cool.

For the internal ingress my understanding was that we will drop that and use the mesh interface instead, or maybe I misunderstood?

@wood-push-melon @shipperizer should we keep tests for traefik to be sure that we don't break that integration or we no longer care about that??

Yeah, no charm changes required generally. The ingress interface is reused.

(I might be wrong too) For the internal ingress, what I understand is that (at the current stage) we still need "something" to let the HTTPRoutes attach to, so that the traffic coming from other k8s clusters will get routed to different hydra listening ports. And this "something" will be another istio ingress (Gateway) at the current point. I saw there is some initiative called GAMMA, which lets us bind HTTPRoutes to k8s svc. It looks like an ongoing development.

I think we will no longer care about traefik in the future. But happy to hand it over to you two's decisions :)

@shipperizer
Copy link
Contributor

So no charm changes were required? Cool.

For the internal ingress my understanding was that we will drop that and use the mesh interface instead, or maybe I misunderstood?

@wood-push-melon @shipperizer should we keep tests for traefik to be sure that we don't break that integration or we no longer care about that??

as discussed at standup, let s drop the internal ingress and use the service mesh

@wood-push-melon
Copy link
Contributor Author

So no charm changes were required? Cool.
For the internal ingress my understanding was that we will drop that and use the mesh interface instead, or maybe I misunderstood?
@wood-push-melon @shipperizer should we keep tests for traefik to be sure that we don't break that integration or we no longer care about that??

as discussed at standup, let s drop the internal ingress and use the service mesh

yep, will make it in another PR.

@wood-push-melon wood-push-melon merged commit 9311ea1 into track/istio Nov 28, 2024
3 checks passed
@wood-push-melon wood-push-melon deleted the IAM-1219 branch November 28, 2024 22:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants