Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Delete clients when oauth relation is broken #33

Merged
merged 12 commits into from
Mar 29, 2023
Merged

Delete clients when oauth relation is broken #33

merged 12 commits into from
Mar 29, 2023

Conversation

nsklikas
Copy link
Contributor

Add peer relation that will be used for deleting clients when the oauth relation is broken

@nsklikas nsklikas requested a review from a team as a code owner March 10, 2023 12:52
@nsklikas nsklikas requested a review from gruyaume March 10, 2023 12:52
@nsklikas nsklikas force-pushed the IAM-66-oauth-interface branch 2 times, most recently from f88d479 to ffbb535 Compare March 14, 2023 14:17
@nsklikas nsklikas mentioned this pull request Mar 14, 2023
Merged
3 tasks
gruyaume
gruyaume reviewed Mar 14, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@nsklikas nsklikas force-pushed the IAM-66-oauth-interface branch from ffbb535 to ff38052 Compare March 16, 2023 12:03
@nsklikas nsklikas force-pushed the IAM-187-add-peer-relation branch 3 times, most recently from 2dc6b6b to 0e838a4 Compare March 17, 2023 17:12
Base automatically changed from IAM-66-oauth-interface to main March 22, 2023 15:26
@nsklikas nsklikas force-pushed the IAM-187-add-peer-relation branch from 0e838a4 to 4b60a72 Compare March 22, 2023 16:15
@nsklikas nsklikas requested a review from gruyaume March 23, 2023 15:12
natalian98
natalian98 reviewed Mar 24, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
@nsklikas nsklikas force-pushed the IAM-187-add-peer-relation branch from 16c1190 to c733953 Compare March 27, 2023 14:06
@nsklikas nsklikas requested a review from a team March 27, 2023 14:11
gruyaume
gruyaume previously approved these changes Mar 27, 2023
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
@nsklikas nsklikas requested a review from a team March 28, 2023 11:10
@nsklikas nsklikas enabled auto-merge March 28, 2023 11:11
@nsklikas nsklikas disabled auto-merge March 29, 2023 11:54
@nsklikas nsklikas merged commit 411cb7d into main Mar 29, 2023
@nsklikas nsklikas deleted the IAM-187-add-peer-relation branch March 29, 2023 11:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@massigori massigori massigori left review comments

@natalian98 natalian98 natalian98 approved these changes

@gruyaume gruyaume gruyaume left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nsklikas @gruyaume @natalian98 @massigori