Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

IAM-259-Add COS Integration to Hydra #67

Merged
merged 7 commits into from
May 31, 2023
Merged

Conversation

bencekov
Copy link
Contributor

Integrating Hydra charm with COS components: Prometheus and Loki

cos integrations manual testing instructions:

These instructions presuppose that you have a juju cluster with working hydra, prometheus-k8s, and loki-k8s integrated with hydra. Hydra charm uses the default relation names.

Prometheus:
curl 'prometheus_url:9090/api/v1/query?query=http_requests_total&app=hydra&code=200&endpoint=/admin/health/alive' | yq
If you get a list of metrics, then it worked.

Loki
curl loki_url:3100/loki/api/v1/label/juju_unit/values
If your unit shows up in the results, it should be good.

@bencekov bencekov requested a review from a team as a code owner May 18, 2023 13:58
@bencekov bencekov requested a review from gruyaume May 19, 2023 11:53
gruyaume
gruyaume previously approved these changes May 19, 2023
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
@natalian98
Copy link
Contributor

Can we have some example prometheus rule added? Sth like here

src/charm.py Outdated Show resolved Hide resolved
@bencekov bencekov requested review from natalian98 and gruyaume May 26, 2023 13:47
@bencekov bencekov force-pushed the IAM-259-Hydra-COS-Integration branch from 563f452 to 4bd4cdc Compare May 26, 2023 15:24
natalian98
natalian98 previously approved these changes May 29, 2023
gruyaume
gruyaume previously approved these changes May 29, 2023
@bencekov bencekov dismissed stale reviews from gruyaume and natalian98 via 5b1930b May 29, 2023 15:53
@bencekov bencekov force-pushed the IAM-259-Hydra-COS-Integration branch from 1cb9064 to 6ed642a Compare May 31, 2023 15:20
@bencekov bencekov requested a review from natalian98 May 31, 2023 15:26
Copy link
Contributor

@natalian98 natalian98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but please wait for the CI to pass

@bencekov bencekov merged commit 2ac85c8 into main May 31, 2023
@bencekov bencekov deleted the IAM-259-Hydra-COS-Integration branch May 31, 2023 16:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants