-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
IAM-259-Add COS Integration to Hydra #67
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruyaume
previously approved these changes
May 19, 2023
natalian98
reviewed
May 22, 2023
Can we have some example prometheus rule added? Sth like here |
natalian98
reviewed
May 25, 2023
bencekov
force-pushed
the
IAM-259-Hydra-COS-Integration
branch
from
May 26, 2023 15:24
563f452
to
4bd4cdc
Compare
natalian98
previously approved these changes
May 29, 2023
gruyaume
previously approved these changes
May 29, 2023
…level for hydra, and added unit tests
bencekov
force-pushed
the
IAM-259-Hydra-COS-Integration
branch
from
May 31, 2023 15:20
1cb9064
to
6ed642a
Compare
natalian98
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but please wait for the CI to pass
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Hydra charm with COS components: Prometheus and Loki
cos integrations manual testing instructions:
These instructions presuppose that you have a juju cluster with working hydra, prometheus-k8s, and loki-k8s integrated with hydra. Hydra charm uses the default relation names.
Prometheus:
curl 'prometheus_url:9090/api/v1/query?query=http_requests_total&app=hydra&code=200&endpoint=/admin/health/alive' | yq
If you get a list of metrics, then it worked.
Loki
curl loki_url:3100/loki/api/v1/label/juju_unit/values
If your unit shows up in the results, it should be good.