-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Move images in docs to GitHub #3942
Conversation
edbeb4b
to
065eef3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3942 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 255 255
Lines 14603 14603
=======================================
Hits 13014 13014
Misses 1589 1589 ☔ View full report in Codecov by Sentry. |
Thanks for looking at this, @xmkg , perhaps you can help me figure out why those checks are failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for a small apostrophe I've noticed in the docs. All images that are supposed to be seen are visible and relevant to the context. Commented-out ones are not visible, as they should be.
docs/how-to-guides/manage-instances/run-a-docker-container-in-multipass.md
Outdated
Show resolved
Hide resolved
Hi @giuliazanchi, can you rebase this branch to |
6d4b324
to
f2921b4
Compare
I've removed (commented out) all image links and placed the images in a separate folder (
docs/images
).NOTE: To build the docs locally, go in the
docs
folder and run the commandmake run
. To see the available documentation checks and targets, just runmake
.You can view a preview of the updated docs on RTD here: https://canonical-multipass--3942.com.readthedocs.build/en/3942/