Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove old Discourse footer from all pages #3945

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

giuliazanchi
Copy link
Contributor

@giuliazanchi giuliazanchi commented Feb 21, 2025

This PR removes the Discourse footer from all pages, linking the Multipass docs feedback google form and the GitHub issue creator link. Since moving docs to RTD, these are no longer necessary.

EDIT - I also commented out the manual list of contributor that was added to a small set of pages on Discourse, as it was only experimental and will not be maintained further.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (f5c1102) to head (bb33dab).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3945   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         255      255           
  Lines       14603    14603           
=======================================
  Hits        13014    13014           
  Misses       1589     1589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xmkg xmkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the contributors are commented out in some parts. Is that intentional?

@giuliazanchi
Copy link
Contributor Author

I noticed that the contributors are commented out in some parts. Is that intentional?

Hi @xmkg , yes, the reason I hid them is because only some pages included the list of contributors on Discourse, and it was added manually, so it's by no means complete throughout the docs. The original contributors will still be visible on the source Discourse topics and the new contributors will be automatically included in the new Sphinx docs.

I didn't delete them but simply commented these out so that if, for any reason, you want to be able to still see who contributed to those pages, it will remain visible in the source files.

@xmkg xmkg added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 21, 2025
@xmkg xmkg added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit c3ec76c Feb 21, 2025
16 checks passed
@xmkg xmkg deleted the docs-remove-old-footer branch February 21, 2025 18:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants