Setting up allure for integration tests #491
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 88 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 19 | 1 | 68 | 0 |
Click to see the invalid file list
- .github/workflows/allure_report.yaml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
license-eye has checked 96 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 20 | 6 | 70 | 0 |
Click to see the invalid file list
- python/cli/allure_add_default_for_missing_results/init.py
- python/cli/allure_add_default_for_missing_results/allure_add_default_for_missing_results.py
- python/cli/pyproject.toml
- python/pytest_plugins/allure_pytest_collection_report/init.py
- python/pytest_plugins/allure_pytest_collection_report/_plugin.py
- python/pytest_plugins/allure_pytest_collection_report/pyproject.toml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
license-eye has checked 96 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 20 | 6 | 70 | 0 |
Click to see the invalid file list
- python/cli/allure_add_default_for_missing_results/init.py
- python/cli/allure_add_default_for_missing_results/allure_add_default_for_missing_results.py
- python/cli/pyproject.toml
- python/pytest_plugins/allure_pytest_collection_report/init.py
- python/pytest_plugins/allure_pytest_collection_report/_plugin.py
- python/pytest_plugins/allure_pytest_collection_report/pyproject.toml
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
There was a problem hiding this comment.
LGTM!
Minor nits :)
As of newlines, https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline i think this might help reason about why its required:D
python/cli/allure_add_default_for_missing_results/allure_add_default_for_missing_results.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks fine, please get a review from @weiiwang01 as the senior review in this case
|
Thank you for adding this, I think it will help us improve our tests a lot! |
Overview
Integrated Allure tool for visualization of integration tests.
Rationale
This integration is required so that we can analyse the reasons for failure of integration tests better.
Workflow Changes
python/pytest-pluginsfor setting the default result status as unknown for all tests during collection time.allure-add-default-for-missing-resultsis defined to merge the results obtained from the collection time with the actual results.Checklist
urgent,trivial,complex)Results
Here's an example report from github-runners repo using this workflow.