-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add the ability to compare two Plan objects with == and create a Plan from a dict #1134
Conversation
The spacing lint errors in pebble.py and docs/conf.py are ones that Ruff wants. This seems to be a change in 0.2.2 (#9266), but I'm not sure why it didn't show up in the PR that bumped ruff to 0.2.2. I'll make the adjustments, since they seem minorly better than |
Do you mean the PR that bumped ruff to 0.2.1? (1836df5#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449) I wonder if we should pin an exact version for Ruff, if this is going to be a problem (particularly as we have preview turned on). |
Ha, yes. I remembered it going to 0.2 and assumed it must have been 0.2.2 but the "why did it change" obvious answer is indeed that 😂. We currently have it I'd be fine pinning it to an exact version (we could reconsider at 1.0.0 maybe). In the other hand, if the changes tend to be small, I'm also fine with just dealing with them as they come, since we have a small team, so don't generally have a lot of PRs at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Agreed overall -- some minor comments and changes requested.
Heh, Pyright-style "semver". :-)
Okay, let's leave as is for now, and we can always reconsider if it keeps being a problem. |
This PR adds two minor features to
pebble.Plan
objects to simplify testing (particularly with Scenario):pebble.Plan
objects, or aPlan
with adict
, with==
- comparison to any other type of object will still return False.pebble.Plan
object from apebble.PlanDict
(or equivalent dict).This aligns the
Plan
functionality withLayer
objects.