fix(Harness): remove special-casing for get_relation
in leader-elected
#1156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Juju, using
get_relation()
in a leader-elected event will returnNone
if the relation does not yet exist. This makes Harness consistent with that behaviour.This does remove a safety-check for badly written tests - where you mean for the relation to exist but forget to do an
add_relation()
call first in the test. However, we don't have any sort of check like this for any other events, or any other types of relations, and it should be obvious when the test fails that it's failing to find an expected relation, and the solution is to set that relation up. I don't think it's worth having a warning for this specific case (we don't warn in other similar situations).This also means we can remove a check in model.py that's a no-op in production and does work in Harness, which is a bad smell, in my opinion.
Done:
Fixes #1153