-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
docs: add release step to update pinned charm tests #1213
Conversation
Like this, right? #1215 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, two very small suggestions.
Co-authored-by: Tony Meyer <tony.meyer@canonical.com>
Co-authored-by: Tony Meyer <tony.meyer@canonical.com>
Now that the automatic charm pin update workflow has landed, the wording of the step needs an update.
I've updated the wording for the "check/update charm pins" step in the release procedure. I've decided not to include the rollback step, as I figure that newer charm version failing against pre-release ops code should probably block the release, require figuring out what happened and sorting things out manually in general. |
We will switch to using pinned versions of the charm (latest `main`) for our charm tests in the GitHub Actions. This PR adds a release step to update the pinned versions, and what to do if they fail. --------- Co-authored-by: Tony Meyer <tony.meyer@canonical.com> Co-authored-by: Dima Tisnek <dima.tisnek@canonical.com>
We will switch to using pinned versions of the charm (latest
main
) for our charm tests in the GitHub Actions. This PR adds a release step to update the pinned versions, and what to do if they fail.