Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: fix links in HACKING.md #1236

Merged
merged 3 commits into from
Jun 4, 2024
Merged

docs: fix links in HACKING.md #1236

merged 3 commits into from
Jun 4, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented May 29, 2024

Fix the links to version.py so that they render correctly.

HACKING.md Outdated Show resolved Hide resolved
HACKING.md Outdated Show resolved Hide resolved
@tonyandrewmeyer
Copy link
Contributor

A description for the PR, even if it's just one sentence, would be good.

@dimaqq dimaqq requested review from benhoyt and tonyandrewmeyer May 29, 2024 04:19
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - those were my typos, I imagine.

@dimaqq dimaqq force-pushed the hacking-links-fix branch from e614ecb to 92aa39c Compare May 29, 2024 04:43
@dimaqq
Copy link
Contributor Author

dimaqq commented May 29, 2024

GitHub indicates that a new review from @benhoyt is necessary

@tonyandrewmeyer tonyandrewmeyer merged commit 6120ee8 into main Jun 4, 2024
51 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the hacking-links-fix branch June 4, 2024 02:00
tonyandrewmeyer pushed a commit to tonyandrewmeyer/operator that referenced this pull request Jun 26, 2024
Fix the links to [version.py](ops/version.py) so that they render
correctly.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants