ci: validate PR title against conventional commit rules #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
force-pushed
the
ci-enfroce-conventional-commit-prs
branch
from
63d14d8 to
0b00e4c
Compare
|
Validated that this works: dimaqq#28 |
benhoyt
reviewed
Jun 18, 2024
tonyandrewmeyer
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Thanks!
Looks good to me. I did not look at the upstream source to verify that it's not doing anything bad (particularly with the token we are providing) - I'm not super well placed to do that in JS. The upstream repo seems fairly healthy, which is a positive indicator.
tonyandrewmeyer
pushed a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Jun 26, 2024
As documented in canonical#1252 - types taken from the doc PR - scopes were scraped from project PR history
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #1252