Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: run ruff format over charm pin update code #1278

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer commented Jun 27, 2024

The only changes are from running tox -e fmt, and adding ruff format --preview check to the tox -e lint commands.

I don't think these changes are generally important, being in a separate file only used in CI, but ideally running tox -e fmt doesn't bring in unrelated changes when working on a branch, and we might as well be consistent.

@dimaqq
Copy link
Contributor

dimaqq commented Jun 27, 2024

A worthy change… was the file excluded from pre commit and/or tox?

if so, let’s include it.

if it was included , then I’m doubly sorry for having merged it regardless!

@tonyandrewmeyer
Copy link
Contributor Author

A worthy change… was the file excluded from pre commit and/or tox?

if so, let’s include it.

It was included in the formatting but not in the linting. I've added that too, now.

@IronCore864 IronCore864 merged commit 0857042 into canonical:main Jun 28, 2024
29 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants