Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: rework ops.main type hints to allow different flavours (callable class) #1345

Merged
merged 33 commits into from
Sep 3, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
21b7f48
newer style annotations
dimaqq Aug 23, 2024
96b4edc
use keep-runtime-typing
dimaqq Aug 27, 2024
8ce4210
newer style annotations
dimaqq Aug 23, 2024
6148420
use keep-runtime-typing
dimaqq Aug 27, 2024
7e8493c
fix: rework ops.main type hints to allow different import flavours
dimaqq Aug 26, 2024
7d351b6
mock things correctly
dimaqq Aug 27, 2024
b3e14da
newer style annotations
dimaqq Aug 23, 2024
8a786b9
fix: rework ops.main type hints to allow different import flavours
dimaqq Aug 22, 2024
2678252
test: split up #1331 tests
dimaqq Aug 26, 2024
aaf22d1
fix: rework ops.main type hints to allow different import flavours
dimaqq Aug 22, 2024
0120397
add test modile docstring
dimaqq Aug 26, 2024
54a3330
test: split up #1331 tests
dimaqq Aug 26, 2024
2ae8a1c
chore: deprecate ops.main.main()
dimaqq Aug 26, 2024
b80fc1a
chore: deprecate ops.main.main() pt 2
dimaqq Aug 26, 2024
ab338bb
chore: deprecate ops.main.main() pt 3
dimaqq Aug 27, 2024
8d65e7f
wip: Protocol
dimaqq Aug 27, 2024
5893b5e
polish🧼
dimaqq Aug 28, 2024
173981f
polish🧼
dimaqq Aug 28, 2024
627b96d
polish🧼
dimaqq Aug 28, 2024
877897e
fix: rework ops.main type hints to allow different import flavours
dimaqq Aug 22, 2024
c863615
test: split up #1331 tests
dimaqq Aug 26, 2024
f3c6359
use a plain class
dimaqq Aug 28, 2024
bac26ca
Update the docs
dimaqq Aug 29, 2024
7f58996
docstring fixes
dimaqq Aug 29, 2024
e8b253b
plug doc build issue for now
dimaqq Aug 29, 2024
6113684
address review comments
dimaqq Aug 29, 2024
8de35e3
address review comments
dimaqq Aug 29, 2024
b0379f7
move argv[0] where it belongs
dimaqq Aug 29, 2024
bcffd43
update type tests to mirror backwards compatiblity
dimaqq Sep 2, 2024
a2f724e
compact docstring
dimaqq Sep 2, 2024
64e2184
copyright header spacing
dimaqq Sep 2, 2024
ede4507
re-export symbols that scenario 6 uses
dimaqq Sep 2, 2024
8c0290d
test bug
dimaqq Sep 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
compact docstring
  • Loading branch information
dimaqq committed Sep 2, 2024
commit a2f724ec1cc25e72d9db6fd38c876f157b7a4ebf
5 changes: 1 addition & 4 deletions ops/__init__.py
Original file line number Diff line number Diff line change
@@ -346,10 +346,7 @@ def main(

import ops


class SomeCharm(ops.CharmBase):
...

class SomeCharm(ops.CharmBase): ...

if __name__ == "__main__":
ops.main(SomeCharm)