Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: coverage report generation should also include testing/src/scenario #1453

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

tonyandrewmeyer
Copy link
Contributor

Include testing/src/scenario/ in the coverage analysis.

Additionally, move the (TIOBE required) repositioning of the coverage XML file into the tox command, since it's only used for TIOBE now, and this slightly simplifies the work (since we can use the --data-file and -o options for coverage).

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused about GHA @vn specifiers.

This source seems to suggest that if it's a tag, then that very tag will be used:
https://github.com/orgs/community/discussions/48058

And TIOBE repo v3 is a tag, while the newest is v3.2.1 (also a tag).

tox.ini Show resolved Hide resolved
@tonyandrewmeyer
Copy link
Contributor Author

I'm a little confused about GHA @vn specifiers.

This source seems to suggest that if it's a tag, then that very tag will be used: https://github.com/orgs/community/discussions/48058

And TIOBE repo v3 is a tag, while the newest is v3.2.1 (also a tag).

It looks like TIOBE update the v3 tag to point at the latest v3, so pinning to v3 is the simpler choice because then we don't need to continually update it every time there is a new release.

image

@dimaqq dimaqq merged commit 77b85ee into canonical:main Nov 15, 2024
31 checks passed
@tonyandrewmeyer
Copy link
Contributor Author

This was waiting for a review, so shouldn't really have been merged yet.

@dimaqq
Copy link
Contributor

dimaqq commented Nov 15, 2024

Oh, it got two reviews, I figured that should be good enough.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants