feat: support starting and stopping Pebble checks, and the checks enabled field #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
reviewed
Feb 4, 2025
tonyandrewmeyer
commented
Feb 12, 2025
| def _render_services(self) -> Dict[str, pebble.Service]: | ||
| services: Dict[str, pebble.Service] = {} | ||
| for key in sorted(self._layers.keys()): | ||
| layer = self._layers[key] | ||
| for name, service in layer.services.items(): | ||
| # TODO: merge existing services https://github.com/canonical/operator/issues/1112 |
There was a problem hiding this comment.
Drive-by: that ticket is closed, and it looks like this is already done.
|
The pack failure is: I assume this is a temporary problem with the store - I'll retry the job later. |
benhoyt
requested changes
Feb 13, 2025
| @@ -1475,6 +1516,7 @@ def __repr__(self): | |||
| 'CheckInfo(' | |||
| f'name={self.name!r}, ' | |||
| f'level={self.level}, ' | |||
| f'startup={self.startup}, ' | |||
There was a problem hiding this comment.
Ben, repeat after me: "dataclasses are good, use them next time". :-)
| @@ -2126,7 +2168,9 @@ def autostart_services(self, timeout: float = 30.0, delay: float = 0.1) -> Chang | |||
| return self._services_action('autostart', [], timeout, delay) | |||
|
|
|||
| def replan_services(self, timeout: float = 30.0, delay: float = 0.1) -> ChangeID: | |||
| """Replan by (re)starting changed and startup-enabled services and wait for them to start. | |||
| """Replan by (re)starting changed and startup-enabled services and checks. | |||
There was a problem hiding this comment.
It's a pity I called this replan_services, but oh well, at least it's called just replan for the Container method. Not worth deprecating/aliasing here, I think.
There was a problem hiding this comment.
Yeah, that was my thinking as well.
benhoyt
approved these changes
Feb 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for:
startupfield in Pebble checks.start_checksandstop_checksPebble API calls.Harness (and Scenario, mostly via re-using the Harness implementation) is adjusted to more closely simulate the Changes implementation of Pebble Checks, so that the 'if the change ID is the empty string, the check is inactive' behaviour can be simulated.
A subtle bug with notices and check-infos is also fixed: previously the mocked Pebble would gather all notices and check-infos from all containers in the state, instead of only those that are in the correct container.
Pebble PR