Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Storage tests: add a missing test_ method prefix #80

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Storage tests: add a missing test_ method prefix #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/test_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ def test_status_is_app_forced_kwargs(self):
with self.assertRaises(TypeError):
case()

def storage_tool_errors(self):
def test_storage_tool_errors(self):
test_cases = [(
lambda: fake_script(self, 'storage-list', f'echo fooerror >&2 ; exit 1'),
lambda: self.backend.storage_list('foobar'),
Expand All @@ -740,17 +740,17 @@ def storage_tool_errors(self):
lambda: fake_script(self, 'storage-add', f'echo fooerror >&2 ; exit 1'),
lambda: self.backend.storage_add('foobar', count=2),
ops.model.ModelError,
[['storage-get', '-s', 'foobar', 'someattr', '--format=json']],
[['storage-add', 'foobar=2']],
), (
lambda: fake_script(self, 'storage-add', f'echo fooerror >&2 ; exit 1'),
lambda: self.backend.storage_add('foobar', count=object),
TypeError,
[['storage-get', '-s', 'foobar', 'someattr', '--format=json']],
[],
), (
lambda: fake_script(self, 'storage-add', f'echo fooerror >&2 ; exit 1'),
lambda: self.backend.storage_add('foobar', count=True),
TypeError,
[['storage-get', '-s', 'foobar', 'someattr', '--format=json']],
[],
)]
for do_fake, run, exception, calls in test_cases:
do_fake()
Expand Down