require tests to pass on a commit before we publish it to pypi #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it with actions in my own fork. If anybody else wants to confirm that it does what we want. You can enable actions on your fork, push this branch up to your github fork, and then create a tag and publish a release pointing to this commit (on your fork). Then check the github actions and make sure that the tests have to run before the pypi publishing stuff runs. |
pengale
approved these changes
Aug 19, 2022
pengale
approved these changes
Aug 30, 2022
|
@PietroPasotti - want to take a pass over this? |
jnsgruk
approved these changes
Aug 31, 2022
PietroPasotti
approved these changes
Aug 31, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help prevent mistakes like I just did (tagging the wrong commit for a release).