Replace "# type: T" comments with proper variable type annotations #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're using Python 3.8+ the more modern syntax is available to us, so use it. Also re-enable Pyright's reportTypeCommentUsage setting.
The second commit in this PR also removes a bunch of unneeded "noqa" and "pyright" comments.
I used a little script to find these and do a regex replace, then fixed up the few remaining ones (that were split on multiple lines) manually. Then I ran the following script to dump the AST (removing "annotated assignments") and did a diff against the original AST to ensure I hadn't messed up anything else.