Some documentation changes

paas_app_charmer/_gunicorn/logrotate.py

@@ -7,10 +7,13 @@
 
 It will be injected into the container and does not depend on non-standard libraries.
 """
+
 import argparse
 import datetime
 import glob
 import os
+
+# this script runs similarly to a shell script, disable the warning for using subprocess
 import subprocess  # nosec B404
 import time
 

tests/unit/flask/test_charm.py

@@ -97,9 +97,24 @@ def test_log_rotate(tmp_path):
     files = list(tmp_path.iterdir())
     assert len(files) == 1
     archive = files[0]
+    # if the filename doesn't match the pattern, a ValueError will be raised here
     datetime.datetime.strptime(archive.name, "access-%Y-%m-%d-%H-%M-%S.log")
 
 
+def test_log_rotate_not_rotated(tmp_path):
+    """
+    arrange: create a small log file
+    act: run the log rotate function
+    assert: the log file should not be rotated
+    """
+    log_file = tmp_path / "access.log"
+    log_file.touch()
+    assert not logrotate.rotate(str(log_file.absolute()))
+    assert log_file.exists()
+    files = list(tmp_path.iterdir())
+    assert len(files) == 1
+
+
 def test_log_rotate_cleanup(tmp_path):
     """
     arrange: create a log file larger than the max log file size, along with many archive files