-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[DPE-4683] socket config flag #343
base: main
Are you sure you want to change the base?
Conversation
dragomirp
commented
Aug 23, 2024
•
edited
Loading
edited
- Add configuration flag to use socket
- Pass socket endpoint and URI based on the config flag
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 75.20% 75.05% -0.16%
==========================================
Files 9 9
Lines 1319 1323 +4
Branches 239 240 +1
==========================================
+ Hits 992 993 +1
- Misses 254 256 +2
- Partials 73 74 +1 ☔ View full report in Codecov by Sentry. |
config.yaml
Outdated
local_connection_type: | ||
default: localhost | ||
description: | | ||
Type of local connectivity to provide. Must be either 'localhost' or 'socket'. Only applies to the database interface. | ||
type: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vIP value will already control how exposed connections will behave, so adding config just for local connections.
4b1684c
to
3bcf09c
Compare
Let's rather have as possible values: |