ant plugin, gradle plugin: add support for authenticated proxies #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thank you. |
sergiusens
changed the title
sergiusens
approved these changes
Aug 17, 2017
sergiusens
added
the
bug
9 tasks
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Sep 21, 2017
…onical#1490) LP: #1682534 Bring ant and gradle up to par with maven plugin wrt. authenticated proxies. Fixes canonical#1485 and re-fixes the linked LP bug.
|
@kalikiana I'm trying to run the ant plugin on the build servers but I still appear to be having this problem (ant downloads fail). Do I need to do something special in my snapcraft.xml file to make the ant plugin check for the proxies? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP: #1682534
ant plugin, gradle plugin: Add support for authenticated proxies
Bring ant and gradle up to par with maven plugin wrt. authenticated proxies. Fixes #1485 and re-fixes the linked LP bug (AFAICT it doesn't need the unauthenticated proxy that @cjwatson suggested in the LP bug)