Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds sriov-network-device-plugin rock #2

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

claudiubelu
Copy link
Contributor

Based on the Dockerfile: https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/v3.6.2/images/Dockerfile

Using ubuntu@22.04 as a base since we're supposed to run /entrypoint.sh, which needs to run commands.

@claudiubelu claudiubelu marked this pull request as draft July 22, 2024 07:49
@claudiubelu claudiubelu force-pushed the adds-rock branch 2 times, most recently from c222fef to e36b7d1 Compare July 22, 2024 08:03
@claudiubelu claudiubelu marked this pull request as ready for review July 22, 2024 08:24
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only a minor styling comment.

3.6.2/rockcraft.yaml Outdated Show resolved Hide resolved
@bschimke95
Copy link
Collaborator

The Dockerfile also copies the ddptool into the image: https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/v3.6.2/images/Dockerfile#L15

Don't we need that as well?

@claudiubelu claudiubelu marked this pull request as draft July 23, 2024 07:50
@bschimke95
Copy link
Collaborator

I must be blind...
thanks!

@claudiubelu claudiubelu marked this pull request as ready for review July 23, 2024 08:28
Based on the Dockerfile: https://github.com/k8snetworkplumbingwg/sriov-network-device-plugin/blob/v3.6.2/images/Dockerfile

Using ubuntu@22.04 as a base since we're supposed to run
/entrypoint.sh, which needs to run commands.

Set the entrypoint-service to install-cni since the daemonsets do not
override the entrypoint, and they pass arguments in.
@bschimke95 bschimke95 merged commit 8202690 into canonical:main Jul 23, 2024
4 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants